Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve title rendering on menu bar change #13317

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jan 25, 2024

What it does

Closes #13311

Awaits the first rendering of the menu bar and then updates the title widget position.

How to test

  1. Resize the electron window until the title widget disappears.
  2. Change the menu bar visibility preference.
  3. Confirm that the title widget appears/disappears as expected.

Review checklist

Reminder for reviewers

@msujew msujew added electron issues related to the electron target ui/ux issues related to user interface / user experience menus issues related to the menu labels Jan 25, 2024
Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe we should wait until we get another response from the corresponding bug report?

@msujew
Copy link
Member Author

msujew commented Jan 25, 2024

I'm fine with waiting, the next release won't happen for a while anyway 👍

@msujew
Copy link
Member Author

msujew commented Feb 20, 2024

I'll merge this for now. If the other issue crops up again, I'm happy to create another PR.

@msujew msujew merged commit 25a84b2 into master Feb 20, 2024
14 checks passed
@msujew msujew deleted the msujew/fix-title-menu-update branch February 20, 2024 17:10
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 20, 2024
This was referenced Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron issues related to the electron target menus issues related to the menu ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Switching the menu bar causes the custom title to be misplaced
2 participants