Improved notebook scrolling behaviour #13338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbicker
changed the title
msujew
approved these changes
Feb 1, 2024
Signed-off-by: Jan Bicker <jan.bicker@typefox.io>
jbicker
force-pushed
the
jbicker/improve-notebook-scrolling
branch
from
92f23bf
to
2949bc7
Compare
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As adressed in #12863 it improves the behaviour of the notebook scrolling by adding react-perfect-scrollbar directly to the notebooks cell list.
How to test
Follow the "How to test" instructions #12442 and hover toolbar items and enjoy a scrollbar which does not hide behind the toolbar.
Review checklist
Reminder for reviewers