Upgrade msgpackr to 1.10.1. Fixes #13363 #13365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/core/package.json
Outdated
| @@ -211,4 +211,4 @@ | |||
| "nyc": { | |||
| "extends": "../../configs/nyc.json" | |||
| } | |||
| } | |||
| } | |||
There was a problem hiding this comment.
minor: we should revert and keep a newline at the end of files.
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 8, 2024
Resolutions: - `nano@^10.1.3`, - `msgpackr@^1.10.1`, - `axios@^1.6.7` Fixes: - [GHSA-wf5p-g6vw-rhxx](GHSA-wf5p-g6vw-rhxx) (`CVE-2023-45857`) - [GHSA-jchw-25xp-jwwc](GHSA-jchw-25xp-jwwc) (`CVE-2023-26159`) - [GHSA-7hpj-7hhx-2fgx](GHSA-7hpj-7hhx-2fgx) (`CVE-2023-52079`) Ref: nrwl/nx#20493 Ref: eclipse-theia/theia#13365 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 8, 2024
Resolutions: - `nano@^10.1.3`, - `msgpackr@^1.10.1`, - `axios@^1.6.7` Fixes: - [GHSA-wf5p-g6vw-rhxx](GHSA-wf5p-g6vw-rhxx) (`CVE-2023-45857`) - [GHSA-jchw-25xp-jwwc](GHSA-jchw-25xp-jwwc) (`CVE-2023-26159`) - [GHSA-7hpj-7hhx-2fgx](GHSA-7hpj-7hhx-2fgx) (`CVE-2023-52079`) Ref: nrwl/nx#20493 Ref: eclipse-theia/theia#13365 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
4 tasks
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 14, 2024
Resolutions: - `nano@^10.1.3`, - `msgpackr@^1.10.1`, - `axios@^1.6.7` Fixes: - [GHSA-wf5p-g6vw-rhxx](GHSA-wf5p-g6vw-rhxx) (`CVE-2023-45857`) - [GHSA-jchw-25xp-jwwc](GHSA-jchw-25xp-jwwc) (`CVE-2023-26159`) - [GHSA-7hpj-7hhx-2fgx](GHSA-7hpj-7hhx-2fgx) (`CVE-2023-52079`) Ref: nrwl/nx#20493 Ref: eclipse-theia/theia#13365 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
kittaakos
pushed a commit
to arduino/arduino-ide
that referenced
this pull request
Feb 14, 2024
Resolutions: - `nano@^10.1.3`, - `msgpackr@^1.10.1`, - `axios@^1.6.7` Fixes: - [GHSA-wf5p-g6vw-rhxx](GHSA-wf5p-g6vw-rhxx) (`CVE-2023-45857`) - [GHSA-jchw-25xp-jwwc](GHSA-jchw-25xp-jwwc) (`CVE-2023-26159`) - [GHSA-7hpj-7hhx-2fgx](GHSA-7hpj-7hhx-2fgx) (`CVE-2023-52079`) Ref: nrwl/nx#20493 Ref: eclipse-theia/theia#13365 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
tortmayr
approved these changes
Feb 19, 2024
There was a problem hiding this comment.
Changes look good to me. Tests are working again and I did not encounter any new errors when testing the change.
I also played around with the references view to see if the potential issues (#12600 (comment)) are resolved.
So far everything seems to work as expected with the new msgpack version. 👍🏼
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
tsmaeder
force-pushed
the
13363_upgrade_msgpackr
branch
from
738ffb4
to
1fe6e65
Compare
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
See title
Fixes #13363
Contributed on behalf of STMicroelectronics
How to test
Do some general testing of Theia, in particular debugging and using plugins.
Follow-ups
Review checklist
Reminder for reviewers