Show decorations in the editor tabs (#13301) #13371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuebner
force-pushed
the
huebner/editortab-decorator-13301
branch
from
1f671ae
to
09b1d14
Compare
msujew
reviewed
Feb 9, 2024
|
@msujew |
dhuebner
force-pushed
the
huebner/editortab-decorator-13301
branch
from
7c73dbe
to
f1dc185
Compare
Co-authored-by: Mark Sujew <mark.sujew@typefox.io>
dhuebner
force-pushed
the
huebner/editortab-decorator-13301
branch
from
f1dc185
to
997d84e
Compare
msujew
approved these changes
Feb 19, 2024
dhuebner
force-pushed
the
huebner/editortab-decorator-13301
branch
from
997d84e
to
3a795e1
Compare
|
@msujew |
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As described in #13301 there were no git status indication in the editor tabs. Now all decorations contributed to the
DecorationsServiceare rendered in tabs that owned by aNavigatableWidget. This currently includes SCM (git) and Problem decorations.Rendering is controlled with
workbench.editor.decorations.badgespreference.How to test
Open en example workspace, produce some SCM changes and errors. You should see tail decoration appearing in the editor tabs similar to the navigator.
Follow-ups
Review checklist
Reminder for reviewers