Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WorkspaceEdit metadata typing #13395

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

tsmaeder
Copy link
Contributor

What it does

Fixes #13355

Contributed on behalf of STMicroelectronics

How to test

This is purely a typing change.

Follow-ups

Review checklist

Reminder for reviewers

Fixes eclipse-theia#13355

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder added the vscode issues related to VSCode compatibility label Feb 17, 2024
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @tsmaeder

@tsmaeder tsmaeder merged commit 384557b into eclipse-theia:master Feb 20, 2024
13 of 14 checks passed
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
This was referenced Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] WorkspaceEdit.set can now contain undefined Metadata with 1.86
3 participants