Allow updates of CompositeMenuNode properties (#12948) #13425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JonasHelming, could you please suggest a reviewer for this PR? Thank you in advance! |
jonah-iden
approved these changes
Feb 28, 2024
- refactor updateOptions function to allow updates - add unit test cases for updateOptions Fixes eclipse-theia#12948
ndoschek
force-pushed
the
issues/12948
branch
from
b9ef0cf
to
e9dbb39
Compare
|
Thank you for the swift review, @jonah-iden! I've updated the imports in the test file and revised my commit accordingly. |
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR refines the
updateOptionsmethod in theCompositeMenuNodeclass.Previously, the method would only update the properties if they were undefined to begin with (due to the the nullish coalescing operator). With the updated implementation,
updateOptionsnow allows properties to be updated.(Please also see my use case description in the linked issue description)
Allow updates of
CompositeMenuNodepropertiesupdateOptionsfunction to allow updatesupdateOptionsFixes #12948
How to test
The change is covered by unit tests since there's no existing use case in the example application to demonstrate the updated behavior so far.
These tests confirm the method's functionality across various scenarios, including handling partial updates and dealing with undefined values.
Follow-ups
--
Review checklist
Reminder for reviewers