fix: use correct path for hosted plugin deployer handler #13427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure that plugins can be removed from the deployed plugins location, the correct source path of the plugin must be stored. Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com> Co-authored-by: safisa <safi@k2view.com>
This was referenced Feb 29, 2024
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This patch stores
plugin.rootPathinstead ofplugin.originalPath()as the source location when a plugin is deployed.This ensures that the plugin is deleted from the deployment directory when uninstalled.
Contributed on behalf of STMicroelectronics
Fixes #13379
How to test
~/.theia/deployedPlugins/~/.theia/deployedPlugins/Follow-ups
Review checklist
Reminder for reviewers