Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump API version to 1.86.2 #13429

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

rschnekenbu
Copy link
Contributor

@rschnekenbu rschnekenbu commented Feb 28, 2024

What it does

Increase compatibility version to 1.86.2 as implementation tasks from task #13356 are closed.
Fixes #13357

Contributed on behalf of STMicroelectronics

How to test

Make sure the system starts and built-ins work as expected as described in https://github.com/eclipse-theia/vscode-builtin-extensions/wiki/Produce-and-Publish-the-set-of-vscode-built-in-extensions#local-testing

Review checklist

Reminder for reviewers

@tsmaeder
Copy link
Contributor

tsmaeder commented Feb 29, 2024

The relevante VS Code version seems to be 1.86.2 why not put the API version at that number? https://eclipse-theia.github.io/vscode-theia-comparator/status.html

Contributed on behalf of STMicroelectronics

Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
@rschnekenbu
Copy link
Contributor Author

True! I updated api to 1.86.2 and rebased on master.

@rschnekenbu rschnekenbu changed the title Bump API version to 1.86.0 Bump API version to 1.86.2 Feb 29, 2024
Copy link
Contributor

@tsmaeder tsmaeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@rschnekenbu rschnekenbu merged commit 96685e3 into eclipse-theia:master Feb 29, 2024
14 checks passed
@rschnekenbu rschnekenbu deleted the issues/13357 branch February 29, 2024 12:57
@rschnekenbu
Copy link
Contributor Author

Thanks @tsmaeder!

This was referenced Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] bump API compatibility version to 1.86.2
2 participants