Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed undo redo keybindings for notebook editor #13518

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

this fixes using ctrcmd+z and ctrlcmd+shift+z keybdinings in notebook editor to undo redo notebook edit operations.

How to test

open a notebook add or remove a cell. while a cell editor is focused undo redo should only work for the editor, if no editor is focused undo redo should work for the full notebook

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from jbicker March 22, 2024 14:58
Copy link
Contributor

@jbicker jbicker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine! Thanks.

@jonah-iden jonah-iden merged commit 4b413bd into master Mar 25, 2024
12 of 14 checks passed
@github-actions github-actions bot added this to the 1.48.0 milestone Mar 25, 2024
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
@msujew msujew deleted the jiden/fix-undo-redo-for-notebook-editor branch May 2, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants