added alot more keybings to the notebook editor #13594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
reviewed
Apr 11, 2024
packages/notebook/src/browser/contributions/notebook-actions-contribution.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
msujew
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This adds multiple new keybindings and some commands and preferences to the notebook editor that vscode supports as well:
ctrl+xcut cellctrl+ccopy cellctrl+vpaste cellEnter(new for code cells) focus editorEscunfocus editor/stop markdown editlinenumber preference to activate and deactivate line numbers in cell editors
collapse/expand cell ouptut command
How to test
Open a notebook and test the new commands
Follow-ups
Review checklist
Reminder for reviewers