Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook widget icon on reload #13612

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 17, 2024

What it does

When reloading the app while having a notebook widget open, the icon stays empty, as the icon is registered after the widget has been recreated. This change ensures that the widget icon is reloaded after changes in the label provider that affect the notebook widget.

How to test

  1. Open a notebook editor and reload the app
  2. The icon should be correctly set on the notebook editor (even though it might take a second or two)

Review checklist

Reminder for reviewers

@msujew msujew added ui/ux issues related to user interface / user experience notebook issues related to notebooks labels Apr 17, 2024
@msujew msujew requested a review from jonah-iden April 17, 2024 13:40
Copy link
Contributor

@jonah-iden jonah-iden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msujew msujew merged commit 7ed5fcb into master Apr 22, 2024
11 of 14 checks passed
@msujew msujew deleted the msujew/fix-notebook-widget-icon branch April 22, 2024 15:11
@github-actions github-actions bot added this to the 1.49.0 milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants