Update DropMetada and documentPaste proposed API for 1.88 compatibility #13632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
tsmaeder
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Some evolution was done on proposed API dropMetadata and documentPaste with vs code 1.88. This PR updated the proposed APIs and code when it was implemented. Some parts of this code is still stubbed. This API is evolving quite frequently, it will be evolving again in the next version.
Fixes #13550
Contributed on behalf of ST Microelectronics
How to test
I tested with the builtin extensions markdown and typescript version 1.88.1, there are no additional errors coming. Support for DocumentPasteEditorProvider is stubbed currently.
I also tested that the extension provided in PR #12125 is also still working.
Follow-ups
None until the API is finalized on VS Code side.
Review checklist
Reminder for reviewers