Reorder back-end plugin deployment to prevent early promise resolution #13643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workaround for eclipse-theia#13638 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
|
@cdamus might be a good idea if you had a quick look. |
msujew
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Great, thanks 👍
I assume that this should also fix that @jonah-iden was experiencing when testing #13369.
For me it's typically 27, but yeah, that looks like the same problem. |
No objection from me. Agreed that strictly sequencing the start-up of each class of plug-in makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Upon startup, we the front end indirectly waits for the initial deployment of plugins before loading their contributions. Because of parallel execution of back end/headless deployment, the corresponding promise was resolved too early and the list of plugins was incomplete.
Workaround for #13638
Contributed on behalf of STMicroelectronics
How to test
Repeat the "how to reproduce" from the linked issue. The installed plugins should show up reliably in the UI.
Follow-ups
#13641
#13642
Review checklist
Reminder for reviewers