Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect URI conversions in custom-editors-main.ts #13653

Merged
merged 1 commit into from Apr 29, 2024

Conversation

pisv
Copy link
Contributor

@pisv pisv commented Apr 28, 2024

What it does

Currently, custom-editors-main.ts contains multiple instances of Theia to VSCode URI conversions of the form URI.file(uri.path.toString()), which seem to be incorrect in the general case. This PR replaces them with URI.from(uri.toComponents()) or just uri.toComponents() as appropriate.

How to test

I don't have a specific test case for this, but hopefully it can be verified by code inspection.

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can confirm that custom editors still behave as expected wrt. editing, saving and reloading.

@msujew msujew merged commit 68cb055 into eclipse-theia:master Apr 29, 2024
13 of 14 checks passed
@pisv
Copy link
Contributor Author

pisv commented Apr 29, 2024

@msujew Thank you very much for reviewing!

@pisv pisv deleted the fix-uri-conversions branch April 29, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants