Handle isFileSystemResource context key #13664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
Apr 29, 2024
dhuebner
force-pushed
the
dhuebner/isFileSystemResource-13192
branch
from
7cfa1af
to
86e790e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
As mentioned here the handling for the
isFileSystemResourceis missing in Theia. This prevents menu contributions that are using this key.Context key description: https://code.visualstudio.com/api/references/when-clause-contexts#available-context-keys
How to test
Simplest way to test is to install the Open In External App extension as described in #13535. With this PR applied you should see the "Open in External App" Explorer context menu entry.
Follow-ups
Review checklist
Reminder for reviewers