Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional css to notebook output webviews #13666

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

Added additional css for styling tables to notebook output webviews. Recreating the style vscode has.
injectable so this can be more easily be overwritten to add addtional css in custom IDEs

How to test

Create a notebook with a cell like the following and execute it. The table should look nice

import pandas as pd

pd.DataFrame(
    data={
        "Col1HasAVeryLongName": [1, 2, 4],
        "Col2MediumName": [4, 5, 6],
        "Col3": [7, 8, 11],
    }
)

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew April 29, 2024 14:25
@jonah-iden jonah-iden changed the title Added additional css to notebook ooutput webviews Added additional css to notebook output webviews Apr 29, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks 👍

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden merged commit 11d6cd0 into master Apr 30, 2024
14 checks passed
@github-actions github-actions bot added this to the 1.50.0 milestone Apr 30, 2024
@jonah-iden jonah-iden deleted the jiden/notebook-additional-output-css branch April 30, 2024 12:52
@msujew msujew added the notebook issues related to notebooks label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants