The new "Open With..." command is visible on folders #13678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcdumais-work
added a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jul 8, 2024
Since the following Theia PR, the navigator's context menu "open-with" command only appears when invoked on file nodes. Since we want to open trace folders using this feature, we now re-register the command for folders, as part of the trace viewer extension. Theia PR: eclipse-theia/theia#13678 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
added a commit
to bhufmann/theia-trace-extension
that referenced
this pull request
Jul 8, 2024
Since the following Theia PR, the navigator's context menu "open-with" command only appears/works when invoked on file nodes. Since we want to open trace folders using this feature, we now re-register the command for folders, as part of the trace viewer extension. Theia PR: eclipse-theia/theia#13678 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
marcdumais-work
added a commit
to marcdumais-work/theia-trace-extension
that referenced
this pull request
Jul 11, 2024
Since the following Theia PR, the navigator's context menu "open-with" command only appears/works when invoked on file nodes. Since we want to open trace folders using this feature, we now re-register the command for folders, as part of the trace viewer extension. Theia PR: eclipse-theia/theia#13678 Signed-off-by: Marc Dumais <marc.dumais@ericsson.com> Make our open-with handler be at the top of the list Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Disables 'Open With...' menu contribution for folders.
How to test
Select a file in the explorer view: Context menu should contain an "Open With..." item
Select a folder in the explorer view: Context menu should not contain an "Open With..." item
See also #13672
Follow-ups
Review checklist
Reminder for reviewers