Stub registerMappedEditProvider
#13681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
rschnekenbu
approved these changes
May 6, 2024
| } | ||
|
|
||
| export namespace chat { | ||
| export function registerMappedEditsProvider(documentSelector: DocumentSelector, provider: MappedEditsProvider): Disposable; |
There was a problem hiding this comment.
Maybe adding @stubbed here ?
There was a problem hiding this comment.
A priori, that makes no sense to me: this is the declaration of the API. Isn't the fact that it's stubbed a property of the implementation? Does the API comparator walk the API declarations to find the stubbed flag?
There was a problem hiding this comment.
Yes, the vscode-theia-comparator project runs through theia.d.ts and vscode.d.ts to generate the compatibility report. I would tend to do the same on the proposed.d.ts files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Stub
registerMappedEditProviderFixes #13649
Contributed on behalf of STMicroelectronics
How to test
registerMappedEditProviderbeing undefinedFollow-ups
Review checklist
Reminder for reviewers