Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notebook cell divider size #13745

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

jonah-iden
Copy link
Contributor

What it does

Previously the cell divider height was to small to contain the content so hovering over the last divider in a notebook resulted in a scrollbar being created which changed the width of the notebook editor widget.
This should be fixed now

How to test

  1. open a notebook with more cells than fit on the screen.
  2. Hover over the last cell divider at the bottom of the notebook
  3. No extra scrollbar should appear, and the editor width should not change

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew May 30, 2024 10:06
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonah-iden jonah-iden merged commit cb71d78 into master May 30, 2024
14 checks passed
@jonah-iden jonah-iden deleted the jiden/fix-notebook-cell-divider-size branch May 30, 2024 13:08
@github-actions github-actions bot added this to the 1.50.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants