Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PluginExt#extensionKind properly #13763

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 4, 2024

What it does

Closes #8871

Adds a new constant isRemote that identifies whether the backend lives on a remote system. We reuse this info to give the plugin host the correct information about the extensionKind property.

How to test

  1. Download and install this test plugin
  2. Start Theia in browser mode and run the Display Extension Kind command. Assert that it shows Workspace.
  3. Start Theia in Electron mode and run the same command. It shows UI.
  4. From the Electron mode connect to a remote machine via SSH (or the dev-container feature). Running the command should show Workspace.

Review checklist

Reminder for reviewers

@msujew msujew added vscode issues related to VSCode compatibility remote issues related to the remote functionality labels Jun 4, 2024
Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could test with success on Theia example browser, electron and connected on remote using a dev container.
Code looks good also. Thanks @msujew!

@msujew msujew merged commit 1f08797 into master Jun 24, 2024
14 checks passed
@msujew msujew deleted the msujew/support-extension-kind branch June 24, 2024 13:19
@github-actions github-actions bot added this to the 1.51.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
remote issues related to the remote functionality vscode issues related to VSCode compatibility
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

vs.extensions.getExtension(...).extensionKind returns incorrect value of ExtensionKind.UI
2 participants