Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved shown keybindings in context menu #13830

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

jonah-iden
Copy link
Contributor

What it does

This improves the visible keybindings in context menus by not showing keybindings that are inactive in the current context.

How to test

For example add a keybinding like this to some keybinding contribution

 {
        command: CommonCommands.UNDO.id,
        keybinding: 'z',
        when: 'notebookEditorFocused',
}

previously this was the always shown as Z in the context menu regardless of if a notebook editor was focused.

Now this should still normally be ctrl/cmd+z but when a notebook editor is focused it should show as Z

Follow-ups

Review checklist

Reminder for reviewers

Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
Signed-off-by: Jonah Iden <jonah.iden@typefox.io>
@jonah-iden jonah-iden requested a review from msujew June 20, 2024 08:53
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jonah-iden jonah-iden merged commit a5f03f8 into master Jun 20, 2024
13 of 14 checks passed
@jonah-iden jonah-iden deleted the jiden/shown-keybindings-in-context-menu branch June 20, 2024 11:17
@github-actions github-actions bot added this to the 1.51.0 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants