Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure UI loads when minimized. #13887

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented Jul 4, 2024

What it does

Fixes #13798

Contributed on behalf of STMicroelectronics

How to test

  1. Remove the splash screen settings in examples/electron/package.json and rebuild
  2. Start Theia with theia electron start and immediately minimize the window
  3. Wait until nothing moves in the command line log
  4. Unminimize the Window
  5. Observe: the UI is already done rendering (no "loading" indicator).

Follow-ups

Review checklist

Reminder for reviewers

@tsmaeder tsmaeder requested a review from rschnekenbu July 4, 2024 16:05
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jul 4, 2024

@JonasHelming I suspect this might speed up loading in the presence of a splash screen, as well.

Copy link
Contributor

@rschnekenbu rschnekenbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, Theia electron was still loading while minimized.

Fixes eclipse-theia#13798

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
@tsmaeder tsmaeder merged commit a3c03bf into eclipse-theia:master Jul 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Theia app is not loading while minimized at startup
2 participants