[WIP] Plug-in System #1618
Closed
[WIP] Plug-in System #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evidolob
force-pushed
the
isolated-extension-api
branch
2 times, most recently
from
7a16f17
to
a52fe2a
Compare
|
@evidolob Could you please use rebase and force to get rid of master changes? It is hard to review now. |
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
evidolob
force-pushed
the
isolated-extension-api
branch
2 times, most recently
from
dbb9e7b
to
142aaaa
Compare
Also move to dev dependencies the core package so plugin's won't have transitive dependencies to core Change-Id: I2b08265ba411fdf561d52b822dde3c517622a3f3 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
…e, Linking is performed dynamically by providing '@theia/plugin' object on the fly Only the module declaration should be exported in package.json -> So we provide a node cache entry of '@theia/plugin' on the fly Change-Id: I3af8883122c2d0ecfad94c69c1eaf15cb94a0071 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Change-Id: I5288617ebdf93469d33fe0e1508919ea137657d5 Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
benoitf
force-pushed
the
isolated-extension-api
branch
from
67d5a7e
to
9f2ec73
Compare
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
|
closing this PR, will open a new one from the up-to-date branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains POC of the new plugin system.
Discussion about architecture and principles can be found here: #1482