a single ws connection per a window #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@svenefftinge It is still in the progress, but you can try it out. |
svenefftinge
previously approved these changes
Apr 25, 2018
| const { id } = message; | ||
| const channel = this.channels.get(id); | ||
| if (channel) { | ||
| channel.fireOpen(); |
There was a problem hiding this comment.
we should at least log if there is a message without a channel
| fireOpen: () => void = () => { }; | ||
| onOpen(cb: () => void): void { | ||
| if (this.toDispose.disposed) { | ||
| return; |
There was a problem hiding this comment.
is registering callbacks on disposed channel not something we want at least log about? Maybe even throw an error?
| protected handleConnection(socket: ws, request: http.IncomingMessage): void { | ||
| const pathname = request.url && url.parse(request.url).pathname; | ||
| if (pathname !== '/services') { | ||
| // TODO shoule we allow other ws connections? |
There was a problem hiding this comment.
should, but, yes, why not allowing multiple different websockets?
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/single_ws_per_window
branch
2 times, most recently
from
75b0109
to
02d7371
Compare
Signed-off-by: Anton Kosiakov <anton.kosyakov@typefox.io>
akosyakov
force-pushed
the
ak/single_ws_per_window
branch
from
02d7371
to
0334978
Compare
akosyakov
changed the title
|
@svenefftinge I've addressed your comments and opened issues for remaining tasks. It is ready for the review. |
svenefftinge
approved these changes
Apr 25, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should make sure that only one ws connection is used per a window. Fixes #1672
TODO: