Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'menus' contribution point for plugins #2955

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Conversation

azatsarynnyy
Copy link
Member

This PR allows a plugin to contribute an item to the menus:

  • navigator context menu;
  • editor context menu.

Optionally, a menu group and an item order within the group can be specified.

Example of the contribution:

"contributes": {
  "menus": {
    "editor/context": [
      {
        "command": "command.id-1",
        "group": "save@4"
      }
    ],
    "explorer/context": [
      {
        "command": "command.id-2",
        "group": "navigation@2"
      }
    ]
  }
}

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy added the plug-in system issues related to the plug-in system label Sep 24, 2018
@azatsarynnyy
Copy link
Member Author

@benoitf could you please take a look at this PR

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@azatsarynnyy azatsarynnyy merged commit bbcc0da into master Sep 25, 2018
@azatsarynnyy azatsarynnyy deleted the plugin/menus branch September 25, 2018 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants