Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CallHierarchyService Plugin API #3765 #4146

Closed
wants to merge 1 commit into from
Closed

CallHierarchyService Plugin API #3765 #4146

wants to merge 1 commit into from

Conversation

vrubezhny
Copy link
Contributor

Issue #3765

Signed-off-by: Victor Rubezhny vrubezhny@redhat.com

@AlexTugarev
Copy link
Contributor

Hi @vrubezhny! 'Just discovered this PR using the initially proposed calls protocol extension.

Recently I've updated the protocol proposal as requested. Please have a look and align.

A dev release of the TS LS implementing the updated callHierarchy protocol is published as well. The update for Theia callhierarchy extension is in progress.

@vrubezhny
Copy link
Contributor Author

vrubezhny commented Jan 23, 2019

Hi @AlexTugarev !

I'll take a look/ Thank you for let me notest!

Issue #3765

Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
@tsmaeder
Copy link
Contributor

@benoitf @evidolob @AlexTugarev ping?

@tsmaeder tsmaeder mentioned this pull request Aug 14, 2019
24 tasks
@AlexTugarev
Copy link
Contributor

AlexTugarev commented Aug 14, 2019

microsoft/vscode-languageserver-node#420 was accepted 🎉 , so it would make sense to update. same applies to #4154 btw 😞

@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Aug 14, 2019
* @param service A call hierarchy provider.
* @return A [disposable](#Disposable) that unregisters this provider when being disposed.
*/
export function registerCallHierarchyProvider(selector: DocumentSelector, provider: CallHierarchyProvider): Disposable;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it proposed api? Please move it theia.proposed.d.ts

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should copy it from here: https://github.com/microsoft/vscode-languageserver-node/blob/51ce5233b6f97a4e2b6bee8f729205774a243140/client/src/callHierarchy.proposed.ts#L185-L234

Please don't forget a CQ. ping @theia-ide/ip-help if you need any help with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants