Fix tree node capitalization outside of nav #4694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4692 The PR #4670 introduced changes which meant that the navigator's file tree's first node was capitalized among other styling updates. Since other components use the same `class` `theia-FileTree`, those components were also updated as a consequence. This PR addresses that issue by making sure only the navigator gets the new styling by using its `id` instead of the generic class. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
the
ui/ux
elaihau
approved these changes
Mar 25, 2019
svenefftinge
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4692
The PR #4670 introduced changes which meant that the navigator's file tree's
first node was capitalized among other styling updates. Since other components
use the same
classtheia-FileTree, those components were also updated as aconsequence. This PR addresses that issue by making sure only the navigator
gets the new styling by using its
idinstead of the generic class.Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com