align "configure task" with vs code #5776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 20, 2019 16:43
… workspace - fixed #4919 Signed-off-by: Liang Huang <liang.huang@ericsson.com>
- in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus `problemMatcher`, are written into tasks.json. (fixed #5679) - `TaskConfigurations.taskCustomizations` is a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders. Signed-off-by: Liang Huang <liang.huang@ericsson.com>
- The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed #5747) - The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed #5719) Signed-off-by: Liang Huang <liang.huang@ericsson.com>
|
Configure tasks in different root folders of a multi root workspace:
Once a detected task is configured, it is displayed as a configured task:
The configured detected task cannot be configured for more than once:
Lastly, as the GIFs shown above, with this change, "configure task" does not write the entire task object into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align "task quick open" in Theia with vs code
The detected tasks, once customized, should be displayed as configured tasks in the quick open. (fixed Configuring of a task #5747)
The same task shouldn’t have more than one customization. Otherwise it would cause ambiguities and duplication in tasks.json (fixed "configure task" should not add duplications to task.json #5719)
Signed-off-by: Liang Huang liang.huang@ericsson.com
align "configure task" in Theia with vs code
in the current Theia, when users configure a detected task, the entire task config is written into tasks.json, which introduces redundancy. With this change, only properties that define the detected task, plus
problemMatcher, are written into tasks.json. (fixed users shouldn't have the flexibility of customizing all properties of a detected task #5679)TaskConfigurations.taskCustomizationsis a flat array, and the user can only customize one type of detected task in one way. With this change Theia supports having different ways of task customization in different root folders.Signed-off-by: Liang Huang liang.huang@ericsson.com
edit the right task.json when clicking "configure task" in multi-root workspace
Signed-off-by: Liang Huang liang.huang@ericsson.com