Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Theia build #6571

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Fix Theia build #6571

merged 1 commit into from
Nov 18, 2019

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Nov 18, 2019

Signed-off-by: Anatoliy Bazko abazko@redhat.com

What it does

It fixes build by setting correct return type in LanguagesMainPluginMetrics.provideCodeActions

Review checklist

Reminder for reviewers

@tolusha
Fix build
48203a0 
Signed-off-by: Anatoliy Bazko <abazko@redhat.com>
@tolusha tolusha mentioned this pull request Nov 18, 2019
Merged
1 task
@tolusha tolusha changed the title Fix Theia buidl Fix Theia build Nov 18, 2019
marcdumais-work
marcdumais-work approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repo builds now and example application works. Thanks for the quick fix, Anatoliy

@tolusha tolusha merged commit d84655d into master Nov 18, 2019
@tolusha tolusha deleted the ab/fixbuild branch November 18, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@marcdumais-work marcdumais-work marcdumais-work approved these changes

@akosyakov akosyakov Awaiting requested review from akosyakov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tolusha @benoitf @marcdumais-work