Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-host] change THEIA_ env exclusion filter #7085

Merged
merged 1 commit into from Feb 5, 2020

Conversation

AlexTugarev
Copy link
Contributor

to match ^THEIA_ instead of THEIA_. this allows to access PREFIX_THEIA_SUFFIX env vars in plug-ins.

Fixes #7084

How to test

  • export PREFIX_THEIA_FOO env var before launching theia backend process
  • use e.g. python vscode extension to debug some code and execute import os; print(os.environ['PREFIX_THEIA_FOO']) to validate

Review checklist

Reminder for reviewers

to match `^THEIA_` instead of `THEIA_`. this allows to access `PREFIX_THEIA_SUFFIX` env vars in plug-ins.

Fixes #7084
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexTugarev
Copy link
Contributor Author

Thanks @svenefftinge and @benoitf!
I'm merging despite of test failures on windows as they looks unrelated.

@AlexTugarev AlexTugarev merged commit 6e1b955 into master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Host swallows PREFIX_THEIA_SUFFIX Env Vars
3 participants