Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): Allow to customise the plugin-host process #7181

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 19, 2020

What it does

Allow to configure through inversify the path of the process to be launched for plug-ins
Fixes #7180

How to test

Launch Theia with plug-ins (or VS Code extensions)
They should work as usual (if process is not found BTW no plug-in can start)

Review checklist

Reminder for reviewers

Change-Id: I6977e799a74238637c50ed7e6845c610c208ec02
Signed-off-by: Florent Benoit fbenoit@redhat.com

@benoitf benoitf added the plug-in system issues related to the plug-in system label Feb 19, 2020
@kittaakos
Copy link
Contributor

Off: Seems like the "no-multiple-empty-lines": "error" rule does not work. See:

Is it a bug or we ignore linter issues on the CI? By the way, I did not see any linter issues in VS Code either. (CC: @marechal-p)

@vince-fugnitto
Copy link
Member

Is it a bug or we ignore linter issues on the CI? By the way, I did not see any linter issues in VS Code either. (CC: @marechal-p)

It looks like a bug, I believe it should be the following:

 "no-multiple-empty-lines": ["error", { "max": 1 }],

This means any other consecutive line (ex: 2 blank will fail).

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the built-in VS Code extensions

Fixes eclipse-theia#7180

Change-Id: I6977e799a74238637c50ed7e6845c610c208ec02
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf
Copy link
Contributor Author

benoitf commented Feb 20, 2020

@kittaakos @vince-fugnitto the extra empty line has been removed

@benoitf
Copy link
Contributor Author

benoitf commented Feb 21, 2020

FYI I will merge today with the approval I got.
if you're against, please raise your hand :-)

@benoitf benoitf merged commit 8ad04be into eclipse-theia:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin] allow to customize plugin-host process
4 participants