Select created new files and folders in the navigator

[vinokurig]

What it does

Add an event that fires when new nodes added to tree.
Select new created files and folders.

fixes #6190
closes #6927

How to test

1. Create new file/folder => the file/folder must be selected.
2. Create new file/folder in selected directory => the file/folder must be selected.
   

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

I don't think it is a good idea, programatically new nodes can be added for all kind of reasons. It does not mean that they should be selected. I don't think we need to change anything in trees, but rather new file/folder commands that they select a node after createFile/Folder requests are done.

[vinokurig]

@akosyakov We still need to wait for the new nodes to be added to the tree, so I've added a new event that fired when the new file/folder action is executed and check if the added node was caused by the action.

[vince-fugnitto]

@akosyakov We still need to wait for the new nodes to be added to the tree, so I've added a new event that fired when the new file/folder action is executed and check if the added node was caused by the action.

It is similar to the initial implementation of #6927 (comment)

[vinokurig]

It is similar to the initial implementation of #6927 (comment)

My implementation is a little bit different: the workspace command events are fired directly from the new file/folder actions.

[vince-fugnitto]

Please see the CI errors related to the test failures.

[vinokurig]

@vince-fugnitto

Please see the CI errors related to the test failures.

done

[akosyakov]

I don't understand why need events, I imagine code like that:

await FileSystem.createFile(uri);
await FileNavigatorWidget.model.refresh(uri.parent);
await FileNavigatorWidget.revealFile(uri); // maybe previous step is not necessary, if `revealFile` does refresh already

[vinokurig]

@akosyakov

I don't understand why need events, I imagine code like that:
await FileSystem.createFile(uri);
await FileNavigatorWidget.model.refresh(uri.parent);
await FileNavigatorWidget.revealFile(uri); // maybe previous step is not necessary, if revealFile does refresh already

I couldn't use navigator in the workspace module because workspace is already used in the navigator, so injecting navigator to workspace causes circular dependency error.

[akosyakov]

I couldn't use navigator in the workspace module because workspace is already used in the navigator, so injecting navigator to workspace causes circular dependency error.

But you can do it otherwise by injecting WorkspaceCommandContribution into FileNavigatorContribution and then:

this.workspaceContribution.onDidCreateNewFolder(uri => {
    const navigator = this.tryGetWidget();
    if (navigator) {
        const parent = await navigator.model.revealFile(uri.parent);
        if (CompositeTreeNode.is(parent)) {
            await navigator.model.refresh(parent);
            const node = await navigator.model.revealFile(uri);
            if (SelectableTreeNode.is(node)) {
                navigator.model.selectNode(node);
            }
        }
    }
});

[vinokurig]

@akosyakov

But you can do it otherwise by injecting WorkspaceCommandContribution into FileNavigatorContribution and then:

   const navigator = this.tryGetWidget();
   if (navigator) {
        const parent = await navigator.model.revealFile(uri.parent);
        if (CompositeTreeNode.is(parent)) {
            await navigator.model.refresh(parent);
            const node = await navigator.model.revealFile(uri);
            if (SelectableTreeNode.is(node)) {
                navigator.model.selectNode(node);
            }
        }
    }
});

done

[akosyakov]

It worked nicely. I've tested:

• with and without navigator (from command palette)
• creating files and folders
• creates with simple name and nested structures (foo/bar/baz)

[akosyakov]

did a quick test, still looks good, squash and merge :)