Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating user-level task #7928

Merged
merged 1 commit into from Jun 3, 2020

Conversation

tsmaeder
Copy link
Contributor

@tsmaeder tsmaeder commented May 29, 2020

Signed-off-by: Thomas Mäder tmader@redhat.com

What it does

Allows to programmatically update user-level tasks. Fixes #7927

How to test

Check out this branch and test the scenario from the linked issue.

Review checklist

Reminder for reviewers

Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsmaeder do you mind updating the changelog to reflect the breaking changes of the methods:

  • addTaskConfiguration
  • setTaskConfigurations
  • saveTask

@vince-fugnitto vince-fugnitto added the tasks issues related to the task system label May 29, 2020
@tsmaeder
Copy link
Contributor Author

@vince-fugnitto the only break folks overriding: calling should be ok.

@vince-fugnitto
Copy link
Member

@vince-fugnitto the only break folks overriding: calling should be ok.

I see since:

export type TaskConfigurationScope = string | TaskScope.Workspace | TaskScope.Global;

My rationale was that it is always good practice to be explicit in the changelog and report any potential breakage for downstream projects. If you don't think it's breakage then I'll leave it up to your discretion.

@tsmaeder
Copy link
Contributor Author

@vince-fugnitto thx for the heads-up.

Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested in the following scenarios:

  • updating problemMatchers for user tasks
  • updating problemMatchers for configured tasks
  • updating problemMatchers for contributed tasks

Thank you for your work.

It would be really helpful if the breaking changes can be documented in the changlog. Thank you !

Copy link
Contributor

@RomanNikitenko RomanNikitenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested for user and workspace level tasks.
It works well for me!

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jun 2, 2020

Added a note about the breaking change.

@tsmaeder tsmaeder merged commit 598d251 into eclipse-theia:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot configure problemMatcher for User-Level Task
4 participants