Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add branch protection rules for node-wot #14

Merged
merged 2 commits into from
Feb 9, 2024

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Feb 9, 2024

No description provided.

Signed-off-by: Cristiano Aguzzi <relu91@users.noreply.github.com>
@relu91 relu91 requested review from a team as code owners February 9, 2024 11:00

This comment has been minimized.

Signed-off-by: Cristiano Aguzzi <relu91@users.noreply.github.com>
Copy link

github-actions bot commented Feb 9, 2024

Diff for c8ed779:
Printing local diff:

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization iot.thingweb[id=eclipse-thingweb]
  there have been 5 validation infos, enable verbose output with '-v' to to display them.

+   add branch_protection_rule[pattern="master", repository="node-wot"] {
+     allows_deletions                  = false
+     allows_force_pushes               = false
+     blocks_creations                  = false
+     bypass_force_push_allowances      = []
+     bypass_pull_request_allowances    = []
+     dismisses_stale_reviews           = false
+     is_admin_enforced                 = false
+     lock_allows_fetch_and_merge       = false
+     lock_branch                       = false
+     pattern                           = "master"
+     require_last_push_approval        = false
+     required_approving_review_count   = "2"
+     required_status_checks            = [
+       "eclipse-eca-validation:eclipsefdn/eca"
+     ],
+     requires_code_owner_reviews       = false
+     requires_commit_signatures        = false
+     requires_conversation_resolution  = false
+     requires_deployments              = false
+     requires_linear_history           = false
+     requires_pull_request             = true
+     requires_status_checks            = true
+     requires_strict_status_checks     = false
+     restricts_pushes                  = false
+     restricts_review_dismissals       = false
+   }
  
  Plan: 1 to add, 0 to change, 0 to delete.
Canonical Diff for c8ed779:
Showing canonical diff:

Organization iot.thingweb[id=eclipse-thingweb]

--- canonical
+++ original
@@ -62,9 +62,7 @@
       allow_merge_commit: true
       allow_update_branch: false
       branch_protection_rules : [
-        orgs.newBranchProtectionRule('master') {
-          required_approving_review_count: 2
-        }
+        orgs.newBranchProtectionRule('master')
       ]
       default_branch: "master"
       delete_branch_on_merge: false

@netomi netomi merged commit 796dd62 into eclipse-thingweb:main Feb 9, 2024
2 checks passed
@netomi
Copy link
Contributor

netomi commented Feb 9, 2024

changes are live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants