Skip to content

Commit

Permalink
chore: clean up TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
JKRhb committed Feb 19, 2022
1 parent 9491f9e commit 3b99b87
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion lib/src/binding_coap/coap_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ class _CoapRequest {
case CoapRequestMethod.get:
return await _coapClient.get();
case CoapRequestMethod.post:
// TODO(JKRhb): Decide how payloads should be handled
payload ??= "";
return await _coapClient.post(payload, format);
case CoapRequestMethod.put:
Expand Down
2 changes: 1 addition & 1 deletion lib/src/binding_http/http_client.dart
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class HttpClient extends ProtocolClient {
{required void Function(Content content) next,
void Function(Exception error)? error,
required void Function() complete}) async {
// TODO: implement subscribeResource
// TODO(JKRhb): implement subscribeResource
throw UnimplementedError();
}

Expand Down
2 changes: 0 additions & 2 deletions lib/src/binding_http/http_client_factory.dart
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class HttpClientFactory extends ProtocolClientFactory {

@override
bool destroy() {
// TODO(JKRhb): Check if there is anything to destroy.
return true;
}

Expand All @@ -31,7 +30,6 @@ class HttpClientFactory extends ProtocolClientFactory {

@override
bool init() {
// TODO(JKRhb): Check if there is anything to init.
return true;
}
}
2 changes: 1 addition & 1 deletion lib/src/binding_http/http_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class HttpServer extends ProtocolServer {

@override
Future<void> expose(ExposedThing thing) {
// TODO: implement expose
// TODO(JKRhb): implement expose
throw UnimplementedError();
}

Expand Down
3 changes: 0 additions & 3 deletions lib/src/core/consumed_thing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,6 @@ class ConsumedThing implements scripting_api.ConsumedThing {

_ClientAndForm _getClientFor(List<Form> forms, OperationType operationType,
_AffordanceType affordanceType, InteractionOptions? options) {
// TODO(JKRhb): This method is mostly taken from node-wot and has to be
// reworked.

if (forms.isEmpty) {
throw ArgumentError(
'ConsumedThing "$title" has no links for this interaction');
Expand Down

0 comments on commit 3b99b87

Please sign in to comment.