feat!: use direct as default Discovery method

eclipse-thingweb · Jun 12, 2022 · cc752d6 · cc752d6
1 parent 32431cc
commit cc752d6
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/example/coap_discovery.dart b/example/coap_discovery.dart
@@ -24,7 +24,6 @@ Future<void> main(List<String> args) async {
   await for (final thingDescription in wot.discover(
     ThingFilter(
       url: Uri.parse('coap://plugfest.thingweb.io:5683/testthing'),
-      method: DiscoveryMethod.direct,
     ),
   )) {
     final consumedThing = await wot.consume(thingDescription);

diff --git a/example/complex_example.dart b/example/complex_example.dart
@@ -159,8 +159,7 @@ Future<void> main() async {
     '/Oracle/oracle-Festo_Shared.td.jsonld',
   );
 
-  final thingDiscovery =
-      wot.discover(ThingFilter(url: thingUri, method: DiscoveryMethod.direct));
+  final thingDiscovery = wot.discover(ThingFilter(url: thingUri));
 
   await for (final thingDescription in thingDiscovery) {
     final consumedDiscoveredThing = await wot.consume(thingDescription);

diff --git a/example/example.dart b/example/example.dart
@@ -51,8 +51,7 @@ Future<void> main(List<String> args) async {
     '/Oracle/oracle-Festo_Shared.td.jsonld',
   );
 
-  final thingDiscovery =
-      wot.discover(ThingFilter(url: thingUri, method: DiscoveryMethod.direct));
+  final thingDiscovery = wot.discover(ThingFilter(url: thingUri));
 
   await for (final thingDescription in thingDiscovery) {
     final consumedDiscoveredThing = await wot.consume(thingDescription);

diff --git a/lib/src/scripting_api/discovery/thing_filter.dart b/lib/src/scripting_api/discovery/thing_filter.dart
@@ -10,12 +10,17 @@ import 'discovery_method.dart';
 ///
 /// See [WoT Scripting API Specification, Section 10.3][spec link].
 ///
+/// Note that the default method here is set to [DiscoveryMethod.direct] instead
+/// of [DiscoveryMethod.directory], contrary to the Scripting API specification.
+/// This might change in future versions, depending on how his part of the
+/// specification is going to evolve.
+///
 /// [spec link]: https://w3c.github.io/wot-scripting-api/#the-thingfilter-dictionary
 class ThingFilter {
   /// Constructor.
   ThingFilter({
     required this.url,
-    this.method = DiscoveryMethod.directory,
+    this.method = DiscoveryMethod.direct,
     this.fragment,
   });