fix(consumed_thing): don't catch all subscribe exceptions

eclipse-thingweb · Feb 19, 2022 · d5c2226 · d5c2226
1 parent 6893e03
commit d5c2226
Showing 1 changed file with 11 additions and 17 deletions.
diff --git a/lib/src/core/consumed_thing.dart b/lib/src/core/consumed_thing.dart
@@ -277,23 +277,17 @@ class ConsumedThing implements scripting_api.ConsumedThing {
     final form = clientAndForm.form; // TODO(JKRhb): Handle URI variables
     final client = clientAndForm.client;
 
-    final subscription = await client.subscribeResource(form,
-        next: (content) {
-          try {
-            listener(InteractionOutput(
-                content, servient.contentSerdes, form, dataSchema));
-          } on Exception {
-            // Exception is handled by onError function. Not sure if this is the
-            // best design, though.
-            // TODO(JKRhb): Check if this try-catch-block can be removed.
-          }
-        },
-        error: (error) {
-          if (onError != null) {
-            onError(error);
-          }
-        },
-        complete: () => removeSubscription(affordanceName, subscriptionType));
+    final subscription = await client.subscribeResource(
+      form,
+      next: (content) => listener(
+          InteractionOutput(content, servient.contentSerdes, form, dataSchema)),
+      error: (error) {
+        if (onError != null) {
+          onError(error);
+        }
+      },
+      complete: () => removeSubscription(affordanceName, subscriptionType),
+    );
     if (subscriptionType == SubscriptionType.property) {
       _observedProperties[affordanceName] = subscription;
     } else {