fix(binding-netconf): use optional chaining for non-null-assertion #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
netconf-null-check
branch
from
9729e06
to
7047b9b
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1079 +/- ##
==========================================
+ Coverage 75.02% 75.04% +0.01%
==========================================
Files 80 80
Lines 15610 15607 -3
Branches 1499 1499
==========================================
Hits 11712 11712
+ Misses 3862 3859 -3
Partials 36 36
☔ View full report in Codecov by Sentry. |
danielpeintner
approved these changes
Sep 12, 2023
|
Given @danielpeintner's approval, I would merge this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #1078, I noticed that there is a warning emitted by eslint regarding the use of
!for non-null-assertions. This PR simply replaces the!s with?(for optional chaining) which should avoid unwanted errors during runtime if one of the parameters should be undefined.