feat!(coap-server): adjust constructor to HTTP server

[JKRhb]

As pointed out by @egekorkan in #1028, the CoAP server currently has a different constructor API that differs from its HTTP counterpart.

This PR introduces a CoapServerConfig interface that features the previously defined address and port parameters in order to align it with the HTTP implementation (and probably also other binding implementations). Using this approach will also make it possible to extend the CoAP server more easily in the feature (e.g., with a security configuration).

As this PR introduces a breaking change, however, I suppose merging it should be postponed until the next minor(?) release.

Will resolve #1028.

[relu91]

LGTM

[relu91]

BTW CI is failing, you have to update also the examples :)

[JKRhb]

BTW CI is failing, you have to update also the examples :)

Should be fixed now :)

[codecov]

Codecov Report

Patch coverage: 61.53% and project coverage change: +0.01% 🎉

Comparison is base (c10fba2) 75.34% compared to head (0cbecdc) 75.35%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1082      +/-   ##
==========================================
+ Coverage   75.34%   75.35%   +0.01%     
==========================================
  Files          80       80              
  Lines       16079    16083       +4     
  Branches     1502     1503       +1     
==========================================
+ Hits        12114    12119       +5     
+ Misses       3926     3925       -1     
  Partials       39       39              

Files Changed	Coverage Δ
packages/cli/src/cli-default-servient.ts	69.37% <25.00%> (+0.33%)	⬆️
packages/binding-coap/src/coap-server.ts	78.93% <50.00%> (-0.09%)	⬇️
packages/binding-coap/src/coap.ts	92.98% <100.00%> (+0.32%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[egekorkan]

A bit of a dangerous question but why aren't the cli package tests (and build) are failing? This effects the following:

• https://github.com/eclipse-thingweb/node-wot/blob/master/packages/cli/src/cli-default-servient.ts#L137
• https://github.com/eclipse-thingweb/node-wot/blob/master/API.md?plain=1#L41C15-L41C15 (fine for now)
• https://github.com/eclipse-thingweb/node-wot/blob/master/examples/templates/exposed-thing/index.js (funny enough that this was actually fortune teller)

So in other words, we need to reflect this in other places

[JKRhb]

Hmm, I guess the build for https://github.com/eclipse-thingweb/node-wot/blob/master/packages/cli/src/cli-default-servient.ts#L137 isn't failing since the corresponding method parameter is typed as any,

[JKRhb]

The issue with the CLI package should now be addressed – however, the typing in that package seems to need some more work.

[danielpeintner]

As this PR introduces a breaking change, however, I suppose merging it should be postponed until the next minor(?) release.

We recently did have a breaking change in binding-http as well in #1070.
I think it is fine to go on...

Anyone opposed to it?