Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(binding-opcua): update opcua modules #1122

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Oct 13, 2023

see #1072

EDIT: The updates pulls in a lot of changes ... but I just simply added/updated dependency after dependency..

npm install node-opcua-address-space@2.113.0 --save-exact
...

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (996ea23) 75.67% compared to head (824bc22) 75.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files          80       80           
  Lines       16159    16159           
  Branches     1520     1520           
=======================================
  Hits        12229    12229           
  Misses       3888     3888           
  Partials       42       42           
Files Coverage Δ
...ackages/binding-opcua/src/opcua-protocol-client.ts 79.90% <50.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM at least this time I didn't spot any foreign changes. 🥳

@relu91
Copy link
Member

relu91 commented Oct 15, 2023

I noticed we have two green, let's go.

@relu91 relu91 merged commit b1d11a0 into eclipse-thingweb:master Oct 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants