Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding-opcua:test fix macOS endpoint #1141

Merged

Conversation

erossignon
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ccea971) 77.12% compared to head (5759048) 77.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1141   +/-   ##
=======================================
  Coverage   77.12%   77.13%           
=======================================
  Files          80       80           
  Lines       16296    16296           
  Branches     1552     1552           
=======================================
+ Hits        12569    12570    +1     
+ Misses       3705     3704    -1     
  Partials       22       22           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erossignon erossignon force-pushed the FixBindingOPCUATestOnMacOS branch 8 times, most recently from df6a573 to 40af85e Compare October 25, 2023 20:28
.github/workflows/ci.yaml Show resolved Hide resolved
@danielpeintner
Copy link
Member

@erossignon Thank you very much for looking into the issue.

As mentioned before I cannot run the opcua tests on Windows either since a while. Seems related to some company network settings.


  1) OPCUA Client
       Y1-0 should read a topic with contentType= application/json:
     Error: Cannot connected to endpoint opc.tcp://<HOSTNAME_MY_MACHINE>:7890
msg = The connection may have been rejected by server,

For the record and maybe to help others as well.
By looking at your investigation and fix I did the same on windows updating %WINDIR%\System32\drivers\etc\hosts with the following line

127.0.0.1 <HOSTNAME_MY_MACHINE>

and the opcua tests are working again 👍
@egekorkan you seemed to have the same issue, right?

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

referring to the issue might help others understand the reason

@erossignon erossignon force-pushed the FixBindingOPCUATestOnMacOS branch 2 times, most recently from 2a2faca to f547ec7 Compare October 26, 2023 20:08
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@relu91 relu91 merged commit 6d127f0 into eclipse-thingweb:master Nov 2, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants