Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(AID): report proper valueType for value #1149

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

danielpeintner
Copy link
Member

fixes #1148

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1441a01) 75.17% compared to head (ea41476) 76.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   75.17%   76.58%   +1.40%     
==========================================
  Files          80       80              
  Lines       16576    16598      +22     
  Branches     1592     1601       +9     
==========================================
+ Hits        12461    12711     +250     
+ Misses       4067     3860     -207     
+ Partials       48       27      -21     
Files Coverage Δ
...s/td-tools/src/util/asset-interface-description.ts 71.90% <66.66%> (-0.14%) ⬇️

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@danielpeintner
Copy link
Member Author

We now have failing MQTT tests :-(
see https://github.com/eclipse-thingweb/node-wot/actions/runs/6732890771/job/18300446252?pr=1149#step:7:401

I have seen that before... re-running the CI helped but we may want to look into if it happens more often..

@danielpeintner
Copy link
Member Author

@danielpeintner danielpeintner merged commit 282dff1 into eclipse-thingweb:master Nov 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AID represents values as string and indicates actual type with valueType
4 participants