feat: check whether property is readOnly or writeOnly on exposed-thing #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@relu91 @egekorkan may I ask you to check what I did ... on writeProperty() call I also added a check whether the property at all exists which makes it a bigger diff but the actual change is minor.. |
egekorkan
approved these changes
Sep 22, 2020
danielpeintner
added a commit
to danielpeintner/thingweb.node-wot
that referenced
this pull request
Nov 10, 2020
API will change for v0.8.x anyway see discussion in eclipse-thingweb#333
danielpeintner
added a commit
that referenced
this pull request
Nov 11, 2020
fix: revert pr #328 for v0.7.x
relu91
pushed a commit
to relu91/thingweb.node-wot
that referenced
this pull request
Jun 1, 2021
API will change for v0.8.x anyway see discussion in eclipse-thingweb#333 Signed-off-by: reluc <relu.cri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #326