Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http-server): implement TD content negotiation #896

Merged
merged 2 commits into from
Dec 15, 2022
Merged

feat(http-server): implement TD content negotiation #896

merged 2 commits into from
Dec 15, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Dec 14, 2022 •
edited

This PR implements a simple content negotiation mechanism for the HTTP binding and adds two an additional tests. In the process, I applied some refactoring to the language negotiation code.

@JKRhb JKRhb force-pushed the http-content-negotiation branch 4 times, most recently from a3180f9 to e6e5853 Compare December 14, 2022 21:28
@JKRhb JKRhb marked this pull request as ready for review December 14, 2022 21:29
danielpeintner
danielpeintner approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@danielpeintner danielpeintner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍

The only thing I would have done is to split the test into 2 tests.
1 for success and 1 for fail but I can also live with it as is ;-)

@JKRhb
Copy link
Member Author

JKRhb commented Dec 15, 2022

Thanks, LGTM 👍

The only thing I would have done is to split the test into 2 tests. 1 for success and 1 for fail but I can also live with it as is ;-)

Thank you for the feedback, should be adjusted now :)

@danielpeintner
Copy link
Member

Great, thanks!
Let's give @relu91 some time to look at the PR as well

relu91
relu91 approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's merge this (thank you also for refactoring!! 🥳 )

@relu91 relu91 merged commit 5561162 into eclipse-thingweb:master Dec 15, 2022
@JKRhb JKRhb deleted the http-content-negotiation branch December 15, 2022 21:54
@JKRhb JKRhb mentioned this pull request Dec 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@danielpeintner danielpeintner danielpeintner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JKRhb @danielpeintner @relu91