Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(binding-http): fix content negotiation #906

Merged
merged 2 commits into from
Jan 16, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Jan 16, 2023

This PR should resolve #905. I already tested the examples in the browser and they are working again :) I will also another test case so that this is also asserted by the CI.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One minor issue in a comment, which we could fix before merging...

packages/binding-http/src/http-server.ts Outdated Show resolved Hide resolved
@danielpeintner danielpeintner merged commit 9364532 into eclipse-thingweb:master Jan 16, 2023
@JKRhb JKRhb deleted the fix-content-negotiation branch January 16, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thing root url on HTTP no longer reports ThingDescription
3 participants