Fix subscribe unsubscribe and then subscribe again MQTT issue #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When subscribing to a topic after unsubscribing from it, the subscription is not performed until the client publish the `connect` event. Since it was already connected with the first subscription the `connect` event is not fired again. This commit fixes this issue by verifying if the client is connected before subscribing to a topic. Fixes eclipse-thingweb#942 Signed-off-by: reluc <relu.cri@gmail.com>
Currently the stop method does not correctly clean the previous subscriptions. This causes the test "should publish and subscribe" to fail because it receives the message sent by the next test. This commit fixes the problem by cleaning the subscription manually. Signed-off-by: reluc <relu.cri@gmail.com>
|
@ilovemilk , I added a small test but it would be nice to get also your feedback. Thank you! |
relu91
commented
Mar 28, 2023
danielpeintner
approved these changes
Mar 28, 2023
|
@relu91 Works perfectly! Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #942 (more explanations about the adopted solution on the commit messages).