-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: proposal for listing maintainers #989
docs: proposal for listing maintainers #989
Conversation
Looks good to me and we can do the same for the other packages if we are fine with this. |
Yes, greenlight also from my side. |
I updated the list of maintainers in all packages. Note1: I tried to look at #508 as well. |
I was wondering if we should also add a
I was thinking the same, wrapping the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took the freedom of adding the link wrappers as suggestions in the comments below:
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Thanks @JKRhb for your updates. I think this PR is now ready for review |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 75.79% 75.62% -0.18%
==========================================
Files 72 72
Lines 14871 14867 -4
Branches 1428 1427 -1
==========================================
- Hits 11272 11243 -29
- Misses 3566 3591 +25
Partials 33 33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks all! |
fixes #986