Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: proposal for listing maintainers #989

Merged
merged 15 commits into from
Jul 4, 2023

Conversation

danielpeintner
Copy link
Member

fixes #986

@egekorkan
Copy link
Member

Looks good to me and we can do the same for the other packages if we are fine with this.

@relu91
Copy link
Member

relu91 commented May 10, 2023

Yes, greenlight also from my side.

@danielpeintner danielpeintner marked this pull request as ready for review June 16, 2023 06:50
@danielpeintner
Copy link
Member Author

danielpeintner commented Jun 16, 2023

I updated the list of maintainers in all packages.
In some cases I have a hard time to pick the right persons.. please let me know what you think, if I forgot anyone etc.

Note1: I tried to look at #508 as well.
Note2: We currently list the people like this @danielpeintner. I think this is not going to become a link.. especially not on NPM. Do we want to add a link to the GitHub account as well or is it fine as is.

@JKRhb
Copy link
Member

JKRhb commented Jun 16, 2023

I was wondering if we should also add a CODEOWNERS file to reflect the responsibilities for the different packages here on GitHub? If so, I could make a proposal for that in a follow-up PR

Note2: We currently list the people like this @danielpeintner. I think this is not going to become a link.. especially not on NPM. Do we want to add a link to the GitHub account as well or is it fine as is.

I was thinking the same, wrapping the @persons into links sounds like a good idea (even though it is a bit tedious).

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took the freedom of adding the link wrappers as suggestions in the comments below:

packages/binding-coap/README.md Outdated Show resolved Hide resolved
packages/binding-http/README.md Outdated Show resolved Hide resolved
packages/binding-mbus/README.md Outdated Show resolved Hide resolved
packages/binding-modbus/README.md Outdated Show resolved Hide resolved
packages/binding-netconf/README.md Outdated Show resolved Hide resolved
packages/td-tools/README.md Outdated Show resolved Hide resolved
packages/core/README.md Outdated Show resolved Hide resolved
packages/cli/README.md Outdated Show resolved Hide resolved
packages/browser-bundle/README.md Outdated Show resolved Hide resolved
packages/binding-mqtt/README.md Outdated Show resolved Hide resolved
danielpeintner and others added 12 commits July 3, 2023 13:32
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
Co-authored-by: Jan Romann <jan.romann@uni-bremen.de>
@danielpeintner
Copy link
Member Author

Thanks @JKRhb for your updates.

I think this PR is now ready for review

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2023

Codecov Report

Merging #989 (24cdafd) into master (96a7fa4) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 24cdafd differs from pull request most recent head e263e49. Consider uploading reports for the commit e263e49 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   75.79%   75.62%   -0.18%     
==========================================
  Files          72       72              
  Lines       14871    14867       -4     
  Branches     1428     1427       -1     
==========================================
- Hits        11272    11243      -29     
- Misses       3566     3591      +25     
  Partials       33       33              

see 2 files with indirect coverage changes

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielpeintner
Copy link
Member Author

Thanks all!

@danielpeintner danielpeintner merged commit 2ed25ab into eclipse-thingweb:master Jul 4, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding maintainers of individual packages to READMEs
5 participants