tracetypes: Remove the few (long) deprecated ctors

Remove these long deprecated constructors in OpenTracingExperiment and
TraceEventEvent, both unused. These were deprecated in commits 227b2c1
and 1f66aba respectively.

Fix these files formatting, based on Eclipse and Sonarlint, while being
in there. Manually reformat @nonnull for fName in TraceEventEvent.

[Removed] o.e.t.i.i.o.c.trace.OpenTracingExperiment#OpenTracingExperiment()
[Removed] o.e.t.i.i.t.c.event.TraceEventEvent#TraceEventEvent()

Change-Id: I33793b4526d4ec6c2e8c650335b34f3ff4d85b49
Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/c/tracecompass.incubator/org.eclipse.tracecompass.incubator/+/193691
Tested-by: Trace Compass Bot <tracecompass-bot@eclipse.org>
Tested-by: Bernd Hufmann <bernd.hufmann@ericsson.com>
Reviewed-by: Bernd Hufmann <bernd.hufmann@ericsson.com>

tracetypes/org.eclipse.tracecompass.incubator.opentracing.core/src/org/eclipse/tracecompass/incubator/internal/opentracing/core/trace/OpenTracingExperiment.java

@@ -25,14 +25,6 @@
  */
 public class OpenTracingExperiment extends TmfExperiment {
 
-    /**
-     * Constructor
-     */
-    @Deprecated
-    public OpenTracingExperiment() {
-        super();
-    }
-
     /**
      * Constructor of an open tracing experiment
      *
@@ -44,10 +36,11 @@ public OpenTracingExperiment() {
      *            The experiment set of traces
      * @param indexPageSize
      *            The experiment index page size. You can use
-     *            {@link TmfExperiment#DEFAULT_INDEX_PAGE_SIZE} for a default value.
+     *            {@link TmfExperiment#DEFAULT_INDEX_PAGE_SIZE} for a default
+     *            value.
      * @param resource
-     *            The resource associated to the experiment. You can use 'null' for
-     *            no resources (tests, etc.)
+     *            The resource associated to the experiment. You can use 'null'
+     *            for no resources (tests, etc.)
      */
     public OpenTracingExperiment(final Class<? extends ITmfEvent> type,
             final String path,

tracetypes/org.eclipse.tracecompass.incubator.traceevent.core/src/org/eclipse/tracecompass/incubator/internal/traceevent/core/event/TraceEventEvent.java

@@ -11,10 +11,8 @@
 
 package org.eclipse.tracecompass.incubator.internal.traceevent.core.event;
 
-import java.util.Collections;
 import java.util.logging.Level;
 
-import org.apache.commons.lang3.StringUtils;
 import org.eclipse.jdt.annotation.NonNull;
 import org.eclipse.jdt.annotation.Nullable;
 import org.eclipse.tracecompass.tmf.core.event.ITmfEventField;
@@ -32,21 +30,9 @@ public class TraceEventEvent extends TmfEvent implements ITmfSourceLookup {
 
     private final @Nullable ITmfCallsite fCallsite;
     private final Level fLogLevel;
-    private @NonNull final String fName;
+    private final @NonNull String fName;
     private final TraceEventField fField;
 
-    /**
-     * Constructor
-     */
-    @Deprecated
-    public TraceEventEvent() {
-        super();
-        fCallsite = null;
-        fLogLevel = Level.OFF;
-        fName = StringUtils.EMPTY;
-        fField = new TraceEventField(StringUtils.EMPTY, 0, "X", null, null, null, null, null, Collections.EMPTY_MAP); //$NON-NLS-1$
-    }
-
     /**
      * Constructor for simple traceEventEvent
      *
@@ -79,6 +65,7 @@ public ITmfEventField getContent() {
     public @Nullable ITmfCallsite getCallsite() {
         return fCallsite;
     }
+
     /**
      * Get the loglevel of the event
      *
@@ -96,4 +83,4 @@ public Level getLevel() {
     public TraceEventField getField() {
         return fField;
     }
-}
+}