opentracing: Add flamegraph analysis to opentracing #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*The AbstractCalledFunction is updated to maintain a list of children Intervals. Because in Async. Executions the overlapped time of children is calculated twice for self time calculation. So we need to maintain a list of time Intervals of children to compute the intersection of them for Self Time Calculations. Signed-off-by: Fariba Daneshgar <faraji.daneshgar@gmail.com>
farajidaneshgar
force-pushed
the
opernTracing
branch
from
58e6523
to
3f0cf28
Compare
arfio
requested changes
May 6, 2024
| @@ -181,5 +181,16 @@ public boolean equals(@Nullable Object obj) { | |||
| Objects.equals(fParent, other.getParent()) && | |||
| Objects.equals(getSymbol(), other.getSymbol())); | |||
| } | |||
|
|
|||
| private long getChildIntersection(TmfTimeRange chlInt) { | |||
There was a problem hiding this comment.
This change should be removed as it does not seem to be used anywhere and changes deprecated classes ?
| @@ -12,12 +12,20 @@ Require-Bundle: org.eclipse.core.runtime, | |||
| org.eclipse.core.resources, | |||
| org.eclipse.tracecompass.common.core, | |||
| org.eclipse.tracecompass.tmf.core, | |||
| org.eclipse.tracecompass.segmentstore.core;bundle-version="3.1.0", | |||
| org.eclipse.tracecompass.incubator.callstack.core;bundle-version="0.1.4", | |||
There was a problem hiding this comment.
Dependencies on org.eclipse.tracecompass.incubator.callstack.core and org.eclipse.tracecompass.incubator.analysis.core should be removed as these projects are mainly deprecated. Other dependencies should not include the bundle-version.
| @@ -40,6 +40,18 @@ | |||
| class="org.eclipse.tracecompass.incubator.internal.opentracing.core.trace.OpenTracingExperiment"> | |||
| </tracetype> | |||
| </module> | |||
| <module | |||
There was a problem hiding this comment.
The indentation and the icon should be corrected.
| * @author Fateme Faraji Daneshgar | ||
| * | ||
| */ | ||
| public class AsincCallStackStateProvider extends AbstractTmfStateProvider { |
There was a problem hiding this comment.
AsincCallStackStateProvider -> AsyncCallStackStateProvider
| @@ -0,0 +1 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
There was a problem hiding this comment.
This package should be internal and if used elsewhere should add an exception in the manifest file. This file also misses the copyright header.
| @@ -0,0 +1,117 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,181 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,178 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,33 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
| @@ -0,0 +1,209 @@ | |||
| package org.eclipse.tracecompass.incubator.opentracing.core.analysis.callstack; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*The AbstractCalledFunction is updated to maintain a list of children Intervals. Because in Async. Executions the overlapped time of children is calculated twice for self time calculation. So we need to maintain a list of time Intervals of children to compute the intersection of them for Self Time Calculations.
Dependent on eclipse-tracecompass/org.eclipse.tracecompass#45