callstack: deprecate all classes that were moved to core #16
Conversation
arfio
force-pushed
the
callstack-deprecated
branch
from
7e2aacc
to
3d18df8
Compare
There was a problem hiding this comment.
The Trace Compass incubator project doesn't provide any releases, since it's an incubator project. However, we update the version number whenever Trace Compass mainline is released, just to have some tracking (even if it's not a release :-)).
So, currently it's at 0.9.0 and you will have to update all deprecated annotations to since="0.10.0". 9.4 is the Trace Compass mainline release and can't be used here. I commented only on 2 representative APIs to change. This comment is valid for all the others.
I noticed that the build is failing, because other plug-ins using deprecated APIs. This are settings that we chose for this project. You, could either change the setting or change the implementation to use the Trace Compass mainline APIs instead. I prefer the latter.
| @@ -27,6 +27,7 @@ | |||
| * | |||
| * @author Geneviève Bastien | |||
| */ | |||
| @Deprecated(since="9.4", forRemoval=true) | |||
| @@ -18,6 +18,7 @@ | |||
| /** | |||
| * @author Geneviève Bastien | |||
| */ | |||
| @Deprecated(since="9.4", forRemoval=true) | |||
arfio
force-pushed
the
callstack-deprecated
branch
from
3d18df8
to
a53040f
Compare
|
Thank you for the review, I have changed the deprecation version argument like you suggested. For the other plug-ins using the deprecated API, I have another pull request opened for this: #18 |
arfio
force-pushed
the
callstack-deprecated
branch
from
a53040f
to
a6a1cf8
Compare
There was a problem hiding this comment.
@arfio To fix the build, change the settings for using deprecated APIs in ROCm plug-in to warning:
arfio
force-pushed
the
callstack-deprecated
branch
from
a6a1cf8
to
ca10788
Compare
Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com>
arfio
force-pushed
the
callstack-deprecated
branch
from
ca10788
to
442cf37
Compare
Deprecate all the classes from callstack and analysis that were moved to core. Change the classes that were not moved to depend on profiling.core and profiling.core.tests.
Dependent on #18 that will remove every dependency to these classes